GlideUrl fix for urls with IPV6 addresses#5444
Conversation
|
Could you please add a test for this? |
|
I assume that you are referring to "Test cases for issues" described in https://bumptech.github.io/glide/tut/failing-test-cases.html . I will work on that. |
|
I am having a problem creating a test case as documented in https://bumptech.github.io/glide/tut/failing-test-cases.html . I followed the directions and created instrumentation/src/androidTest/java/com/bumptech/glide/Issue5444Test.java . Trying to run it by using "Run Issue5444test" results in the following errors: The same happens if I try to run any of the tests that already exist in the directory instrumentation/src/androidTest/java/com/bumptech/glide I tried updating annotation/compiler/proguard.pro by adding -ignorewarnings at the end. This causes the following errors when running my test or existing tests in the directory:: |
There is an existing test file for this class already, GlideUrlTest.java, can you add to that? |
|
I have added a test case to branch issue5444test. The test case fails because of the reported bug and succeeds if you merge this pull request IPV6-fix. The test uses URL http://[2600:1f13:37c:1400:ba21:7165:5fc7:736e]/ which is a valid internet URL. |
|
Thank you! Could you please combine the changes into this PR so they can get tested & merged at the same time? |
IPV6 URLs are of the form http://[2607:f8b0:4006:823::200e]/ but the code was removing the square brackets from the URL, resulting in an invalid URL and a MalformedURLException.
|
As requested, I have rebased and merged issue issue5444test into pull request IPV6-fix. The test runs successfully. |
|
thank you! |
|
Hey, any update here? |
|
Hey there, why 900f060c9ec3ce29e43d9fd9ac7b2dbda6e3d6e3 drop this changes? |
|
The pull request was reversed by a subsequent commit, as noted above by @how8570 . Please fox this. |
|
Hi @falhassen This pull request was reversed by a subsequent commit 900f060, please fix this. |
|
I'm sorry about this. It looks like a configuration issue with a bot. I'll start try to revert this and create a new Glide release that includes the fix. |
…with IPV6 addresses #5444 PiperOrigin-RevId: 805389202
…with IPV6 addresses #5444 PiperOrigin-RevId: 805389202
…with IPV6 addresses #5444 PiperOrigin-RevId: 805434429
|
5.0.5 is out with the fix |
IPV6 URLs are of the form http://[2607:f8b0:4006:823::200e]/ but the code was removing the square brackets from the URL, resulting in an invalid URL and a MalformedURLException.
Description
Cater for IPV6 URLS of the form http://[2607:f8b0:4006:823::200e]/
Motivation and Context
Glide throws exceptions and fails if using IPV6 IP Addresses